From 08e1d9ed58a9d25b804b3893baad2bc8647a2843 Mon Sep 17 00:00:00 2001 From: Sam Chau Date: Tue, 27 Jan 2026 23:27:45 +1030 Subject: [PATCH] feat: explicit NOT NULL to VARCHAR PRIMARY KEY columns in media management --- CHANGELOG.md | 3 +++ ops/0.schema.sql | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5b163fb..24ab2e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -104,4 +104,7 @@ instead of an autoincrement id column. - `radarr_naming.colon_replacement_format`: delete, dash, spaceDash, spaceDashSpace, smart - `radarr_media_settings.propers_repacks`: doNotPrefer, preferAndUpgrade, doNotUpgradeAutomatically - `sonarr_media_settings.propers_repacks`: doNotPrefer, preferAndUpgrade, doNotUpgradeAutomatically +- Added explicit NOT NULL to VARCHAR PRIMARY KEY columns for proper type inference + - `radarr_naming.name`, `sonarr_naming.name`, `radarr_media_settings.name`, `sonarr_media_settings.name` + - SQLite PRIMARY KEY doesn't imply NOT NULL for non-INTEGER columns; explicit declaration needed for type generators diff --git a/ops/0.schema.sql b/ops/0.schema.sql index 458f602..2a1a802 100644 --- a/ops/0.schema.sql +++ b/ops/0.schema.sql @@ -355,7 +355,7 @@ CREATE TABLE sonarr_quality_definitions ( -- Radarr naming configuration CREATE TABLE radarr_naming ( - name VARCHAR(100) PRIMARY KEY, + name VARCHAR(100) NOT NULL PRIMARY KEY, rename INTEGER NOT NULL DEFAULT 1, movie_format TEXT NOT NULL, movie_folder_format TEXT NOT NULL, @@ -368,7 +368,7 @@ CREATE TABLE radarr_naming ( -- Sonarr naming configuration CREATE TABLE sonarr_naming ( - name VARCHAR(100) PRIMARY KEY, + name VARCHAR(100) NOT NULL PRIMARY KEY, rename INTEGER NOT NULL DEFAULT 1, standard_episode_format TEXT NOT NULL, daily_episode_format TEXT NOT NULL, @@ -385,7 +385,7 @@ CREATE TABLE sonarr_naming ( -- Radarr general media settings CREATE TABLE radarr_media_settings ( - name VARCHAR(100) PRIMARY KEY, + name VARCHAR(100) NOT NULL PRIMARY KEY, propers_repacks VARCHAR(50) NOT NULL DEFAULT 'doNotPrefer' CHECK (propers_repacks IN ('doNotPrefer', 'preferAndUpgrade', 'doNotUpgradeAutomatically')), enable_media_info INTEGER NOT NULL DEFAULT 1, @@ -395,7 +395,7 @@ CREATE TABLE radarr_media_settings ( -- Sonarr general media settings CREATE TABLE sonarr_media_settings ( - name VARCHAR(100) PRIMARY KEY, + name VARCHAR(100) NOT NULL PRIMARY KEY, propers_repacks VARCHAR(50) NOT NULL DEFAULT 'doNotPrefer' CHECK (propers_repacks IN ('doNotPrefer', 'preferAndUpgrade', 'doNotUpgradeAutomatically')), enable_media_info INTEGER NOT NULL DEFAULT 1,